Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bike walking through bicycle no thru traffic areas #6179

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Allow bike walking through bicycle no thru traffic areas #6179

merged 1 commit into from
Oct 24, 2024

Conversation

richardkoszegi
Copy link
Contributor

Summary

Allows bike walking through bicycle no thru traffic areas.

Issue

Fixes #6178

Unit tests

Added 3 tests to verify bicycle traverse through bicycle no through edges (the restricted edge is in the start - middle - end).

@richardkoszegi richardkoszegi requested a review from a team as a code owner October 18, 2024 14:04
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev-2.x@f9ea044). Learn more about missing BASE report.
Report is 57 commits behind head on dev-2.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##             dev-2.x    #6179   +/-   ##
==========================================
  Coverage           ?   69.93%           
  Complexity         ?    17734           
==========================================
  Files              ?     1996           
  Lines              ?    75411           
  Branches           ?     7722           
==========================================
  Hits               ?    52741           
  Misses             ?    19993           
  Partials           ?     2677

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vesameskanen vesameskanen self-requested a review October 21, 2024 06:00
vesameskanen
vesameskanen approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some notes, though:

  • I wonder if we should change bicycle nothru island pruning logic now.
  • Would it make sense to filter the first item away from the assertPath func of bikewalk tests?

@optionsome optionsome requested a review from vpaturet October 22, 2024 09:25
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 22, 2024
@optionsome optionsome merged commit 2cc4ac5 into opentripplanner:dev-2.x Oct 24, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request Oct 24, 2024
Add changelog entry for #6179 [ci skip]
06aeadb
@VillePihlava VillePihlava mentioned this pull request Oct 30, 2024
Closed
@t2gran t2gran mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpaturet vpaturet vpaturet approved these changes

@vesameskanen vesameskanen vesameskanen approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.7 (next release)
Development

Successfully merging this pull request may close these issues.

Allow bike walking through bicycle no thru traffic areas
6 participants
@richardkoszegi @vesameskanen @vpaturet @t2gran @optionsome @flaktack